<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Screen turns black during boot after driver tries to set mode on NV50"
href="https://bugs.freedesktop.org/show_bug.cgi?id=55412#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Screen turns black during boot after driver tries to set mode on NV50"
href="https://bugs.freedesktop.org/show_bug.cgi?id=55412">bug 55412</a>
from <span class="vcard"><a class="email" href="mailto:m.b.lankhorst@gmail.com" title="m.b.lankhorst@gmail.com">m.b.lankhorst@gmail.com</a>
</span></b>
<pre>Very easy to see what regressed, though..
upstream commit that made it to mainline is c0077061e7ea, with this:
if (nv_encoder->dcb->lvdsconf.use_acpi_for_edid) {
- if (!nouveau_acpi_edid(dev, connector)) {
+ if (!(nv_connector->edid = nouveau_acpi_edid(dev, connector))) {
status = connector_status_connected;
goto out;
}
Which looks fine, but is inversion of logic. First it returned 0 on success,
now it returns NULL on failure.. Fix would presumably be one line only:
- if (!(nv_connector->edid = nouveau_acpi_edid(dev, connector))) {
+ if ((nv_connector->edid = nouveau_acpi_edid(dev, connector))) {</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>