<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Potential crash bug in src/gallium/auxiliary/rtasm/rtasm_execmem.c" href="https://bugs.freedesktop.org/show_bug.cgi?id=73473#c9">Comment # 9</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Potential crash bug in src/gallium/auxiliary/rtasm/rtasm_execmem.c" href="https://bugs.freedesktop.org/show_bug.cgi?id=73473">bug 73473</a> from <a class="email" href="mailto:jaak@ristioja.ee" title="Jaak Ristioja <jaak@ristioja.ee>"> Jaak Ristioja</a> <pre>Personally, I'd keep both the selinux and PaX parts out of the patch. I suggest simply checking the return value for the mmap call. I think this would suffice. Keep it simple. There are also other reasons why mmap can fail (e.g. due to ulimit) and this should be checked. Please fix this first, add PaX/selinux/whatever support later. :) PS: While in the selinux patch the selinux code can be conditionally #ifdef enabled, in the PaX patch the PaX code is not, meaning this results in a minor performance impact for all users.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>