<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [NVA3, NVA8] gpu lockup during driver probe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=33165#c30">Comment # 30</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [NVA3, NVA8] gpu lockup during driver probe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=33165">bug 33165</a>
from <span class="vcard"><a class="email" href="mailto:oleg@bulatov.mobi" title="Oleg Bulatov <oleg@bulatov.mobi>"> <span class="fn">Oleg Bulatov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=95408" name="attach_95408" title="initialize stuff for gddr5 ram">attachment 95408</a> <a href="attachment.cgi?id=95408&action=edit" title="initialize stuff for gddr5 ram">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=33165&attachment=95408'>[review]</a>
initialize stuff for gddr5 ram
Review of <span class=""><a href="attachment.cgi?id=95408" name="attach_95408" title="initialize stuff for gddr5 ram">attachment 95408</a> <a href="attachment.cgi?id=95408&action=edit" title="initialize stuff for gddr5 ram">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=33165&attachment=95408'>[review]</a>:
-----------------------------------------------------------------
::: drivers/gpu/drm/nouveau/core/subdev/fb/ramnva3.c
@@ +365,5 @@
<span class="quote">> + /* XXX this algorithm is insane, find some sanity to it. */
> + /* [1] MMIO32 R 0x100268 0x30030200 PFB.SUBPART_CONFIG => { SELECT_MASK = 0x2 | UNK16 = 0x3 | ENABLE_MASK = 0x3 } */
> + nv_wr32(pfb, 0x10fcac, 0x00001f01);
> + for (o = 0; o < 4; o++) {
> + int off = offsets[i];</span >
maybe int off = offsets[o]; ?
@@ +387,5 @@
<span class="quote">> + for (i = 0x20, idx = 0; i < 0x30; i++, idx++) {
> + int pat = pattern[2 + (idx % 2)];
> + if (i == 0x26)
> + pat = 0;
> + if (i == 0x1f)</span >
looks like this condition is always false in this for-loop</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>