<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [NVCF] PWM fan speed too high" href="https://bugs.freedesktop.org/show_bug.cgi?id=80901#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [NVCF] PWM fan speed too high" href="https://bugs.freedesktop.org/show_bug.cgi?id=80901">bug 80901</a> from <a class="email" href="mailto:martin.peres@ensi-bourges.fr" title="Martin Peres <martin.peres@ensi-bourges.fr>"> Martin Peres</a> <pre>Comment on <a href="attachment.cgi?id=102433" name="attach_102433" title="PATCH: add LINEAR_MIN and LINEAR_MAX to sysfs">attachment 102433</a> <a href="attachment.cgi?id=102433&action=edit" title="PATCH: add LINEAR_MIN and LINEAR_MAX to sysfs">[details]</a> PATCH: add LINEAR_MIN and LINEAR_MAX to sysfs Thanks, this patch is perfectly sound! However, it doesn't follow the sysfs interface of hwmon as defined here: <a href="https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface">https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface</a> I don't particularly like this interface, but I've tried to stay as close to it as possible. One possibility could be to use the trip points to expose linear_min/max, however, we would be bending the definition of trip point by a long shot (we are not supposed to scale linearly between trip points, at least that's how NVIDIA defines trip points, that's a question worth asking to the hwmon guys). If we are to keep your patch more or less intact, you would have to move your the end result to nouveau_sysfs.c. You would also need to change the name to temp1_fan_linear_min/max, to improve the clarity of what values are expected in there :) Finally, you would need to update the documentation (<a href="http://cgit.freedesktop.org/nouveau/linux-2.6/tree/Documentation/thermal/nouveau_thermal">http://cgit.freedesktop.org/nouveau/linux-2.6/tree/Documentation/thermal/nouveau_thermal</a>). Thanks again for your interest in fixing this!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>