<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [NV1A] 3.18.1 BUG on modprobe nouveau in drivers/gpu/drm/nouveau/core/core/event.c:42"
href="https://bugs.freedesktop.org/show_bug.cgi?id=87552#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [NV1A] 3.18.1 BUG on modprobe nouveau in drivers/gpu/drm/nouveau/core/core/event.c:42"
href="https://bugs.freedesktop.org/show_bug.cgi?id=87552">bug 87552</a>
from <span class="vcard"><a class="email" href="mailto:bonbons67@internet.lu" title="Bruno <bonbons67@internet.lu>"> <span class="fn">Bruno</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=111115" name="attach_111115" title="BUG_ON(!spin_is_locked(lock)) is taboo on UP">attachment 111115</a> <a href="attachment.cgi?id=111115&action=edit" title="BUG_ON(!spin_is_locked(lock)) is taboo on UP">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=87552&attachment=111115'>[review]</a>
BUG_ON(!spin_is_locked(lock)) is taboo on UP
void
nvkm_event_get(struct nvkm_event *event, u32 types, int index)
{
BUG_ON(!spin_is_locked(&event->refs_lock));
while (types) {
int type = __ffs(types); types &= ~(1 << type);
if (++event->refs[index * event->types_nr + type] == 1) {
if (event->func->init)
event->func->init(event, 1 << type, index);
}
}
}
Is it ever valid to do these spin_is_locked() checks on !SMP system?
!SMP system do not have spinlocks at all!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>