<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:j-r@online.de" title="jr <j-r@online.de>"> jr</a> <pre>Thanks for reviewing and fixing the other patch! Meant to send it to the list, but was too busy elsewhere last week. I've been thinking a little about a better way to fix this inbound edge ordering dependency. Unfortunately it seems that unless there is a way to efficiently recompute the information there always will be an invariant that has to be respected by graph transformations (and which attach and detach simply cannot guarantee on their own). And because the PhiMoves pass actually needs the corresponding inbound edge instead of the BB the current encoding makes sense. The conclusion being that neither the encoding of the information nor graph transformations during SSA per se are the real problem. But attach and detach are not the right tools to do graph transformations (at least during SSA). It may be an improvement to add some more high level helpers, e.g. an Edge::split for this particular problem. Would there be interest in a patch in that direction? (Seems easy enough, but I cannot promise I'm up to the task, though:-)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>