<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:j-r@online.de" title="jr <j-r@online.de>"> jr</a> <pre>I do prefer the map based approach over this last attempt. Keeping track of the relevant BB is quite obviously correct, but trying to keep track of edge reordering instead looks like some kind of thimbleriggery to me:-) AFAICT the separate loop added by commit e43a3a66 was an attempt to fix the problem. Attach() and detach() influenced the iterator ei of the loop, possibly creating crashes or endless loops. These symptoms are corrected by the patch, but the real problem - reordering of the edge linked list - is still not accounted for. Your patch shows how to do that correctly. Since my attempt doesn't change the incoming edge list, the separate loop becomes obsolete as a bonus feature. I do like that property, but I don't think it makes much of a difference in practice (since the lists in question are very short).</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>