<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c23">Comment # 23</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:j-r@online.de" title="jr <j-r@online.de>"> jr</a> <pre>(In reply to Ilia Mirkin from <a href="show_bug.cgi?id=90887#c22">comment #22</a>) > (In reply to jr from <a href="show_bug.cgi?id=90887#c21">comment #21</a>) > > Created <a href="attachment.cgi?id=117077" name="attach_117077" title="Prototype of a more highlevel graph modification api">attachment 117077</a> <a href="attachment.cgi?id=117077&action=edit" title="Prototype of a more highlevel graph modification api">[details]</a> <a href='page.cgi?id=splinter.html&bug=90887&attachment=117077'>[review]</a> [review] [review] > > Prototype of a more highlevel graph modification api > > > > ... > > Hrm, I was about to (try to) push this out, but it doesn't seem to work. I > made a few local adjustments, like > > RegAlloc::PhiMovesPass::isCriticalEdge(BasicBlock *b, BasicBlock *p) > { > return b->cfg.incidentCount() > 1 && p->cfg.outgoingCount() > 1; > } > > ... > > > where did BB:4 go? poof. not great :( this is with piglit's > tests/shaders/ssa/fs-critical-edge.shader_test > > I guess I'll go with either your or my first patches. Want to get this fixed > for Mesa 11, which is going to get branched off some time tomorrow. Sorry, most probably my prototype code is crap. I'll have an hour now to look at it. I'll let you know if I find something. Otherwise I'm fine with your first patch.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>