<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c33">Comment # 33</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> Ilia Mirkin</a> <pre>(In reply to jr from <a href="show_bug.cgi?id=90887#c32">comment #32</a>) > (In reply to Ilia Mirkin from <a href="show_bug.cgi?id=90887#c31">comment #31</a>) > > Really if I could understand wtf the needNewElseBlock logic was trying to > > do, and could construct a test shader to hit this in *regular* scenarios, > > not just the lowered output of TXL, that would make me a lot more > > comfortable with any approach that we pick. > > Looking at the TGSI->IR translation I'd guess that needNewElseBlock is > trying to detect the edge from the 'bare' unconditional jump in an if > without else, seemingly because adding the new moves is not allowed (though > I'm not sure why). At least it seems to be the only construct creating a > graph satisfying the condition, AFAICT. Well, in general you can't add work if you have a critical edge -- if an block has multiple outgoing edges, then you can't put the work into that block. If a block has multiple incoming edges, then you can't leave the work in that block, so you have to create a separate block to put work that you want done on that specific block transition. However here it's looking for something much more specific.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>