<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c31">Comment # 31</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> Ilia Mirkin</a> <pre>(In reply to jr from <a href="show_bug.cgi?id=90887#c30">comment #30</a>) > (In reply to Ilia Mirkin from <a href="show_bug.cgi?id=90887#c29">comment #29</a>) > > Hmmmm... maybe it was one of my local patches? I'll try to figure out what > > went wrong later tonight. > > > > I added logic to be clever about edge types... when splitting an edge, the > > type should remain except a forward edge becomes a cross edge. (You can do > > it out on paper...) Perhaps that upset things? It doesn't seem like codegen > > is using those terms in the usual MST meanings :( > > I did take a look at the edge classification. Cannot say I fully understand > the implications yet, but I'm wondering whether the logic in > Graph::classifyDFS is correct. Shouldn't the condition for FORWARD edge > whenn looping over incoming edges (the second loop) be reversed? It's definitely *not* correct. On the bright side, it's never used. I tried using it when I was implementing a SPIR -> NV50 IR converter, and it was a pile of fail. Unfortunately I didn't have time last night to investigate this. But I'll definitely get *some* fix into mesa 11. Sorry this has dragged on for so long. Really if I could understand wtf the needNewElseBlock logic was trying to do, and could construct a test shader to hit this in *regular* scenarios, not just the lowered output of TXL, that would make me a lot more comfortable with any approach that we pick. But really I'm just going to make it return true always, and play around with stuff.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>