<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c38">Comment # 38</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:j-r@online.de" title="jr <j-r@online.de>"> jr</a> <pre>(In reply to Ilia Mirkin from <a href="show_bug.cgi?id=90887#c37">comment #37</a>) > I think this is too big of a problem to fix in a fixup, esp since we don't > really know what these are used for. > > I'm thinking the following: > > (a) Push my fixup patch with the hash map, cc'd to stable. It's a little > inefficient, but it *works*, and is (in my mind) quite simple. I'll > double-check that it doesn't affect perf too much. > (b) Figure out this edge type insanity, including fixing things up, and > maybe adding a validator that makes sure that the edge types are correct. > (c) Revert my fixup, and implement actual edge splitting, (i.e. what you > did) and based on critical edges rather than the current logic. > (d) Lots and lots of testing. > > Does that sound reasonable? One of the considerations here is that neither > you nor I have a *ton* of time to play around with this, and Mesa 11.0.0 > will be released in mid-September, and I'd like to have *some* fix for nv50 > in there. Looks like a good plan. Your patch shouldn't make anything worse and has been tested to fix the reported problems, so this and the other bug can be closed. > As for your patch, the edge is preserved in all cases except forward, which > becomes cross. (draw it out, should make sense, unless I messed up) I'm afk for a week, but will take a longer look. Actually it shouldn't be too difficult, since there are not that many places creating edges.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>