<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - PhiMovesPass in register allocator broken"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c36">Comment # 36</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - PhiMovesPass in register allocator broken"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a>
from <span class="vcard"><a class="email" href="mailto:j-r@online.de" title="jr <j-r@online.de>"> <span class="fn">jr</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=117865" name="attach_117865" title="Edge type fix for prototype patch">attachment 117865</a> <a href="attachment.cgi?id=117865&action=edit" title="Edge type fix for prototype patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=90887&attachment=117865'>[review]</a>
Edge type fix for prototype patch
With this patch on top of the prototype patch edge splitting during
PhiMovesPass should no longer change non forward edges to forward. I think with
current master this isn't a problem, because the split edge will always be a
forward edge, but this still isn't a valid assumption.
After adding the following patch the fs-critical-edge test shows that edge
splitting now preserves the edge type. This patch should also solve the 'all
incoming edges are forward edges' problem that may be the cause of the missing
blocks.
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
index f153674..753bcbf 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
@@ -2838,7 +2838,7 @@ Converter::handleInstruction(const struct
tgsi_full_instruction *insn)
}
if (prevBB->getExit()->op == OP_BRA) {
- prevBB->cfg.attach(&convBB->cfg, Graph::Edge::FORWARD);
+ prevBB->cfg.attach(&convBB->cfg, Graph::Edge::TREE);
prevBB->getExit()->asFlow()->target.bb = convBB;
}
setPosition(convBB, true);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>