<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [nve7] Shadow Warrior: black gun & messed up colors"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91895#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [nve7] Shadow Warrior: black gun & messed up colors"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91895">bug 91895</a>
from <span class="vcard"><a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> <span class="fn">Ilia Mirkin</span></a>
</span></b>
<pre>This patch should get it going, but I don't think I want to commit it as-is.
This gets me the same overly-lit rendering as r600, so any remaining issues are
in the st. Should probably investigate what the "real" rendering looks like,
neither lighting matches any screenshots of the game I've found online.
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
index 0cd21cf..268ea0b 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
@@ -2121,8 +2121,10 @@ RegAlloc::InsertConstraintsPass::insertConstraintMoves()
Instruction *defi = cst->getSrc(s)->defs.front()->getInsn();
// catch some cases where don't really need MOVs
+/*
if (cst->getSrc(s)->refCount() == 1 && !defi->constrainedDefs())
continue;
+*/
LValue *lval = new_LValue(func, cst->src(s).getFile());
lval->reg.size = size;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>