<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887#c39">Comment # 39</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PhiMovesPass in register allocator broken" href="https://bugs.freedesktop.org/show_bug.cgi?id=90887">bug 90887</a> from <a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> Ilia Mirkin</a> <pre>I pushed the following after some light testing: commit a072ef8748a65d286e9b542bb9ea6e020fdcc7f8 Author: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> Date: Thu Sep 10 01:54:30 2015 -0400 nv50/ir: make edge splitting fix up phi node sources But it's not the final word on this stuff... as Béla mentioned in <a href="show_bug.cgi?id=90887#c13">comment 13</a>, some games aren't completely fixed by this. I have some Hearthstone traces (from <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED DUPLICATE - [NV50 gallium] Hearthstone displays corrupted buffers" href="show_bug.cgi?id=75776">bug #75776</a>) which still have minor visual artifacts. Further, they are fixed by splitting more edges. [I made the condition only look at p->cfg.outgoingCount() > 1, which includes a whole lot more than critical edges. This is clearly wrong, but... gives some ideas.]</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>