[Ocs] Review Request: Add accessors for forum and achievements to provider.cpp

Robert Mathias Marmorstein robert at narnia.homeunix.com
Thu Jun 23 13:27:45 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101743/
-----------------------------------------------------------

Review request for Attica and Laszlo Papp.


Summary
-------

A recent commit (72df453ac3b7b400ba88ded1109822f2a07506b0) added four new functions to provider.h, but didn't have the accompanying implementations in provider.cpp.  This breaks building of (at least) smokekde.  The functions are pretty much trivial, but here's my solution.


This addresses bug 276365.
    http://bugs.kde.org/show_bug.cgi?id=276365


Diffs
-----

  lib/provider.cpp 7bd1a17 

Diff: http://git.reviewboard.kde.org/r/101743/diff


Testing
-------

Added functions, compiled, successfully linked against smokekde.  I don't really know how to test this further -- any suggestions are welcome.


Thanks,

Robert Mathias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20110623/e9ce244e/attachment.htm>


More information about the Ocs mailing list