[Ocs] Review Request: Add accessors for forum and achievements to provider.cpp

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101743/#review4107
-----------------------------------------------------------

Ship it!


Looks good. ;) Thank you !

- Laszlo


On June 23, 2011, 8:27 p.m., Robert Mathias Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101743/
> -----------------------------------------------------------
> 
> (Updated June 23, 2011, 8:27 p.m.)
> 
> 
> Review request for Attica and Laszlo Papp.
> 
> 
> Summary
> -------
> 
> A recent commit (72df453ac3b7b400ba88ded1109822f2a07506b0) added four new functions to provider.h, but didn't have the accompanying implementations in provider.cpp.  This breaks building of (at least) smokekde.  The functions are pretty much trivial, but here's my solution.
> 
> 
> This addresses bug 276365.
>     http://bugs.kde.org/show_bug.cgi?id=276365
> 
> 
> Diffs
> -----
> 
>   lib/provider.cpp 7bd1a17 
> 
> Diff: http://git.reviewboard.kde.org/r/101743/diff
> 
> 
> Testing
> -------
> 
> Added functions, compiled, successfully linked against smokekde.  I don't really know how to test this further -- any suggestions are welcome.
> 
> 
> Thanks,
> 
> Robert Mathias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20110623/cb5546c4/attachment.htm>