[Ocs] Review Request: Comment out some qDebug calls

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105358/#review15122
-----------------------------------------------------------


I think Laszlo was working on a similar patch, please check with him. I didn't see how to add people to a review request though.

- Frederik Gladhorn


On June 25, 2012, 1:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105358/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 1:34 p.m.)
> 
> 
> Review request for Attica and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Given that attica is a library, we don't want to flood the user's stdout/stderr with library debug data.
> 
> Comment out the qDebug's, I pondered some of them might be useful in runtime to display the state is not correct. In those cases I changed to qWarning.
> 
> Any opinions?
> 
> 
> Diffs
> -----
> 
>   lib/atticabasejob.cpp c4f0bc8 
>   lib/postfiledata.cpp 5c02976 
>   lib/postjob.cpp 3aed8c9 
>   lib/provider.cpp b7adf0c 
>   lib/providermanager.cpp 5454dbc 
>   lib/putjob.cpp 17b7d51 
>   lib/qtplatformdependent.cpp 8f2a8e6 
> 
> Diff: http://git.reviewboard.kde.org/r/105358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20120625/6feae8f8/attachment.html>