<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101880/">http://git.reviewboard.kde.org/r/101880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 9th, 2011, 6:23 a.m., <b>Constantin-Alexandru Tudorica</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101880/diff/2/?file=26349#file26349line18" style="color: black; font-weight: bold; text-decoration: underline;">lib/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">configure_file(atticaclient_export.h.cmake ${CMAKE_CURRENT_SOURCE_DIR}/atticaclient_export.h)</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) The "client" word was allready there. I modified the other headers to reference the new file (without "client" in it).
2) I thought it will mess out of source builds but apparently it has no such effect. Sorry, bad testing on my part.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In that case, please do not modify the header file name since it is a public, installed file. If some third-party application depends on it, it would break those applications after an attica version update. Also, it is a less intrusive change in that case in general.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On July 9th, 2011, 6:23 a.m., Constantin-Alexandru Tudorica wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Attica and Patrick Spendrin.</div>
<div>By Constantin-Alexandru Tudorica.</div>
<p style="color: grey;"><i>Updated July 9, 2011, 6:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added static build options for libattica.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did a successful build on windows using mingw32 and also linked successfully to the static library. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d45455a)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(a04167f)</span></li>
<li>lib/accountbalance.h <span style="color: grey">(157d84c)</span></li>
<li>lib/achievement.h <span style="color: grey">(96a3fc4)</span></li>
<li>lib/activity.h <span style="color: grey">(b1dddf3)</span></li>
<li>lib/attica_export.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/atticabasejob.h <span style="color: grey">(9259fa3)</span></li>
<li>lib/atticaclient_export.h <span style="color: grey">(bb2e6f1)</span></li>
<li>lib/buildservice.h <span style="color: grey">(6146940)</span></li>
<li>lib/buildservicejob.h <span style="color: grey">(75f9d0c)</span></li>
<li>lib/buildservicejoboutput.h <span style="color: grey">(6011344)</span></li>
<li>lib/category.h <span style="color: grey">(45011d3)</span></li>
<li>lib/comment.h <span style="color: grey">(edc8fa6)</span></li>
<li>lib/content.h <span style="color: grey">(117e624)</span></li>
<li>lib/deletejob.h <span style="color: grey">(6bf79e8)</span></li>
<li>lib/distribution.h <span style="color: grey">(40a867f)</span></li>
<li>lib/downloaddescription.h <span style="color: grey">(f87a4e3)</span></li>
<li>lib/downloaditem.h <span style="color: grey">(3488e11)</span></li>
<li>lib/event.h <span style="color: grey">(bdb1828)</span></li>
<li>lib/folder.h <span style="color: grey">(94a1386)</span></li>
<li>lib/forum.h <span style="color: grey">(f03a0af)</span></li>
<li>lib/getjob.h <span style="color: grey">(ea867d1)</span></li>
<li>lib/homepageentry.h <span style="color: grey">(d0300ad)</span></li>
<li>lib/homepagetype.h <span style="color: grey">(2657304)</span></li>
<li>lib/icon.h <span style="color: grey">(6868e06)</span></li>
<li>lib/itemjob.h <span style="color: grey">(6025c7e)</span></li>
<li>lib/knowledgebaseentry.h <span style="color: grey">(9d71c94)</span></li>
<li>lib/license.h <span style="color: grey">(e7dbee8)</span></li>
<li>lib/listjob.h <span style="color: grey">(3d85d04)</span></li>
<li>lib/message.h <span style="color: grey">(557425f)</span></li>
<li>lib/metadata.h <span style="color: grey">(b3c035b)</span></li>
<li>lib/person.h <span style="color: grey">(e27a297)</span></li>
<li>lib/postjob.h <span style="color: grey">(51fb8d8)</span></li>
<li>lib/privatedata.h <span style="color: grey">(b51b273)</span></li>
<li>lib/project.h <span style="color: grey">(718d822)</span></li>
<li>lib/provider.h <span style="color: grey">(33fcf1a)</span></li>
<li>lib/providermanager.h <span style="color: grey">(67894f8)</span></li>
<li>lib/publisher.h <span style="color: grey">(b55078b)</span></li>
<li>lib/publisherfield.h <span style="color: grey">(2b74297)</span></li>
<li>lib/putjob.h <span style="color: grey">(06d91b5)</span></li>
<li>lib/remoteaccount.h <span style="color: grey">(9ef5edc)</span></li>
<li>lib/topic.h <span style="color: grey">(c043fb8)</span></li>
<li>lib/version.h.cmake <span style="color: grey">(62319b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101880/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>