<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105358/">http://git.reviewboard.kde.org/r/105358/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 25th, 2012, 1:47 p.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think Laszlo was working on a similar patch, please check with him. I didn't see how to add people to a review request though.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was mostly making more professional debug outputs than "Yay.." and so forth. :)
IMO, those outputs are very useful when the library is built in debug mode. If one would not like to see them, they should be able to build release mode, where those are not printed.
What I was actually thinking for the future, is more like loglevels at some point.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On June 25th, 2012, 1:34 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Attica and Frederik Gladhorn.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 1:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given that attica is a library, we don't want to flood the user's stdout/stderr with library debug data.
Comment out the qDebug's, I pondered some of them might be useful in runtime to display the state is not correct. In those cases I changed to qWarning.
Any opinions?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/atticabasejob.cpp <span style="color: grey">(c4f0bc8)</span></li>
<li>lib/postfiledata.cpp <span style="color: grey">(5c02976)</span></li>
<li>lib/postjob.cpp <span style="color: grey">(3aed8c9)</span></li>
<li>lib/provider.cpp <span style="color: grey">(b7adf0c)</span></li>
<li>lib/providermanager.cpp <span style="color: grey">(5454dbc)</span></li>
<li>lib/putjob.cpp <span style="color: grey">(17b7d51)</span></li>
<li>lib/qtplatformdependent.cpp <span style="color: grey">(8f2a8e6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105358/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>