<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105367/">http://git.reviewboard.kde.org/r/105367/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would prefer if you did not submit this. First, why are you trying to work on an unrelated method? Backtraces write about the abort method. Second, I would not like to get anything committed in a rush to a stable module without clear logic why the crash is happening, and why the fix would address that.
I am afraid, this might require more investigation from your side.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On June 26th, 2012, 9:04 p.m., Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Attica.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated June 26, 2012, 9:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Get hot new stuff could easily crash when filtering the retrieved data. The attached bug report shows a lot of backtraces that gave me a nice starting point in fixing this. I'm not quite sure if i fixed it the proper way. Somehow the original code was emitting the current class pointer followed by removing the same class. I simply removed the remove lines (deleteLayer) since the abort function is also cleaning the stuff up. I hope i'm not introducing a memory leak now?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it out with the descriptions in the provided bug. It seems to be working just fine now. No more crashes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=251871">251871</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/atticabasejob.cpp <span style="color: grey">(c4f0bc8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105367/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>