[ooo-build-commit] Branch 'ooo-build-3-1-1' - patches/dev300

Kohei Yoshida kohei at kemper.freedesktop.org
Tue Dec 1 05:27:21 PST 2009


 patches/dev300/calc-r1c1-parse-fix.diff |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

New commits:
commit 88f0ef4a264fcce6294271618e6c99c6b2898870
Author: Kohei Yoshida <kyoshida at novell.com>
Date:   Tue Dec 1 08:25:36 2009 -0500

    Fixed R1C1 parser to have it return correct flag value.
    
    * patches/dev300/calc-r1c1-parse-fix.diff: it failed to return
      SCA_VALID_TAB2 for the range-end address, which caused range
      addresses to be parsed correctly. (n#557475)  BTW Noel put
      the exact same fix way before (around 2.4).  Looks like we lost
      that fix between then and now. :-(

diff --git a/patches/dev300/calc-r1c1-parse-fix.diff b/patches/dev300/calc-r1c1-parse-fix.diff
new file mode 100644
index 0000000..cb28040
--- /dev/null
+++ b/patches/dev300/calc-r1c1-parse-fix.diff
@@ -0,0 +1,15 @@
+diff --git sc/source/core/tool/address.cxx sc/source/core/tool/address.cxx
+index e85ec8d..5a1217a 100644
+--- sc/source/core/tool/address.cxx
++++ sc/source/core/tool/address.cxx
+@@ -631,7 +631,9 @@ lcl_ScRange_Parse_XL_R1C1( ScRange& r,
+ {
+     const sal_Unicode* pTmp = NULL;
+     String aExternDocName, aStartTabName, aEndTabName;
+-    USHORT nFlags = SCA_VALID | SCA_VALID_TAB, nFlags2 = SCA_VALID_TAB2;
++    USHORT nFlags = SCA_VALID | SCA_VALID_TAB;
++    // Keep in mind that nFlags2 gets left-shifted by 4 bits before being merged.
++    USHORT nFlags2 = SCA_VALID_TAB;
+ 
+ #if 0
+     {


More information about the ooo-build-commit mailing list