[Openchrome-devel] xf86-video-openchrome: configure.ac src/via_sii164.c src/via_sii164.h

[Kevin Brace]

Hi Christian,

> I have to excuse myself for my untidiness relating the copyright
> stuff in the code I send to the mailing list some time ago. Luc
> should have been named in the file via_vt1632.c.
> 
> The code wasn't meant to be included directly to the repository.
> It did not work as expected on my system and I asked for some help:
> 
> https://lists.freedesktop.org/archives/openchrome-devel/2014-December/001378.html
> 
> Sorry for the mess. The code was inspired "from kernel source tree
> the viafb module and the drm-openchrome stuff and the Xorg unichrome
> code too".
> 
> I never ever wanted to adore myself with borrowed plumes.
> 
> I agree with Luc that it would be better to merge the SiI164 and VT1632
> code because they are very similar. AFAIK the SiI164 is a clone of
> VIA's VT1632. So I would keep via_vt1632.c and put the SiI164 stuff
> into this one. But feel free to make your own decisions.
> 
> Christian Jung

To be honest, this is the first time I am reading the message you sent in December 2014 to the mailing list.
You did indicate that the code had problems, but it appears that James Simmons went ahead and included the code without much testing. (I did notice that since I observed crashes when activated.)
After working with the code, I noticed that the code had 3 issues, and I ended fixing most of them myself, although one of them (the first one) was really fixed by someone who was knowledgeable than myself at the time.

https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=6964b889d77422ed16972b0ba849d9d5c6574daa
https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=7cb19d9843dcb4cd5107c1a0851403c48b6db6be
https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=56ead733a7aeb0af75c36d8dec566c74dd2e5ece

The code still has a few flaws, and I plan to fix them eventually. (i.e., DVP0 / DVP1 related issues)
    Regarding the copyright issues Luc has raised, I am glad that you came clean with it.
The comments I made to Luc still stands, and I will keep your copyright since you did add some code to the original Luc's code like accessing VT1632(A) register 09H, 0AH, and 0CH, but I will also add his copyright to via_vt1632.c / .h and the derived via_sii164.c / .h.
I do not plan to merge VT1632(A) and SiI 164 code for a while.
I think the case is closed, and I will commit the copyright addition message with the following people signing off on the change.

Suggested-by: Luc Verhaegen <"Luc's e-mail">
Acked-by: JUNG, Christian <"Christian's e-mail">
Signed-off-by: Kevin Brace <"Kevin's e-mail">


Regards,

Kevin Brace