<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - cppcheck report" href="https://bugs.freedesktop.org/show_bug.cgi?id=72088#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - cppcheck report" href="https://bugs.freedesktop.org/show_bug.cgi?id=72088">bug 72088</a> from <a class="email" href="mailto:mrugiero@gmail.com" title="Mario Rugiero <mrugiero@gmail.com>"> Mario Rugiero</a> <pre>Just ran cppcheck again. I will explain the errors I'll fix here, and then provide the patch. First, this one: [src/via_driver.c:1109]: (error) Memory pointed to by 'pEnt' is freed twice. This error is caused because the memory is always freed in line 1031, and all subsequent calls to this are for freeing in the case of errors. This calls will be plainly erased, as not only they aren't checked against it having been freed before (it is, independently of the path, as it is checked only against null and in the first level of indentation, so I assume it is not inside another check), but actually it is already freed always, and not needed anymore. Then, this: [src/via_exa.c:799] -> [src/via_exa.c:808]: (performance) Variable 'nPOTSupported' is reassigned a value before the old one has been used. This one is pretty much trivial, and the fix could be safely ommited. I provide it, anyway, so someone else makes the choice. There are also, pretty thorough to see, fixes in the registers tool, related all to formatting on printf.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>