<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [Patch] VIARestore function improvement" href="https://bugs.freedesktop.org/show_bug.cgi?id=93243#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [Patch] VIARestore function improvement" href="https://bugs.freedesktop.org/show_bug.cgi?id=93243">bug 93243</a> from <a class="email" href="mailto:bensberg@justemail.net" title="Benno Schulenberg <bensberg@justemail.net>"> Benno Schulenberg</a> <pre>(In reply to Kevin Brace from <a href="show_bug.cgi?id=93243#c6">comment #6</a>) > If I have to comply with some kind of a coding style (someone should define > this somewhere), I could. <a href="http://xorg.freedesktop.org/wiki/CodingStyle/">http://xorg.freedesktop.org/wiki/CodingStyle/</a> (the third bullet especially) <a href="http://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting">http://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting</a> <a href="https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=HEAD#l104">https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=HEAD#l104</a> (paragraphs 2) and 3)) Or look at the commit messages from some other project, for example grep: <a href="http://git.savannah.gnu.org/cgit/grep.git">http://git.savannah.gnu.org/cgit/grep.git</a> You will see that the first line (the "50" line) is used as a summary line in the overview. When you click on a commit, this line is even put in bold, and the rest of the message (after the blank line) is show after it, as a self-contained piece of text, not as a continuation of the summary line. > The problem is, I had to create 10 patches before someone stopped me and > told me to do things differently. Well, you posted them very rapidly. But there is no problem whatsoever: first do a 'git format-patch origin' in your current branch. Then checkout the master branch (I supposde you have been making your commits in a branch, if not, you will have to do a git reset --hard HEAD, or make a fresh clone from master elsewhere), and create a new branch. Then apply the 0001* patch, correct the style of the changes, run 'git commit -a', paste in the commit message from the 0001* patch and edit it to be in the summary + blankline + explanation format, and save. Repeat until all patches have been reapplied and recommitted. This is standard procedure for developers. Patches are seldom fully correct the first time around.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>