<div dir="ltr"><div><div><div>Hello Till,<br><br></div>Of course - I will aim for lmcs2, but will do my best to make cups-filters build on lcms1 as well.<br><br></div>As of now, rastertopdf should be able to embed any ICC profile, as long as the profile's data color space matches the color space in the header of the PWG raster (cmsSigRgbData <=> CUPS_CSPACE_RGB). <br>
<br>For testing purposes, please use the "profile=" as a CUPS option, and then specify a local ICC profile path as its value. <br><br></div>Joe<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Aug 9, 2014 at 11:10 AM, Till Kamppeter <span dir="ltr"><<a href="mailto:till.kamppeter@gmail.com" target="_blank">till.kamppeter@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
That's it. It works now. Thank you very much.<br>
<br>
In general you should concentrate your developemnt on working with<br>
lcms2, as lcms1 is not maintained upstream any more and therefore<br>
obsolete. So it must work with lcms2 and support for lcms1 is a plus.<br>
<span class="HOEnZb"><font color="#888888"><br>
Till<br>
</font></span><div class="im HOEnZb"><br>
<br>
On 08/09/2014 06:54 PM, Joseph Simon wrote:<br>
> Dear Till,<br>
><br>
> Please rebuild using rev. 7255 of cups-filters. This should be fixed.<br>
><br>
> Joe<br>
><br>
><br>
> On Fri, Aug 8, 2014 at 11:41 PM, Till Kamppeter<br>
</div><div class="HOEnZb"><div class="h5">> <<a href="mailto:till.kamppeter@gmail.com">till.kamppeter@gmail.com</a> <mailto:<a href="mailto:till.kamppeter@gmail.com">till.kamppeter@gmail.com</a>>> wrote:<br>
><br>
> Sorry, still gives error, probably 32/64-bit issues. I am using 64-bit.<br>
><br>
> Till<br>
><br>
> ----------<br>
><br>
> CXX rastertopdf-rastertopdf.o<br>
> filter/rastertopdf.cpp:86:25: warning: anonymous variadic macros were<br>
> introduced in C99 [-Wvariadic-macros]<br>
> #define dprintf(format, ...) fprintf(stderr, "DEBUG2: (" PROGRAM ") "<br>
> format, __VA_ARGS__)<br>
> ^<br>
> filter/rastertopdf.cpp:88:25: warning: anonymous variadic macros were<br>
> introduced in C99 [-Wvariadic-macros]<br>
> #define iprintf(format, ...) fprintf(stderr, "INFO: (" PROGRAM ") "<br>
> format, __VA_ARGS__)<br>
> ^<br>
> filter/rastertopdf.cpp: In function ‘QPDFObjectHandle<br>
> embedIccProfile(QPDF&)’:<br>
> filter/rastertopdf.cpp:212:56: error: cannot convert ‘size_t* {aka long<br>
> unsigned int*}’ to ‘cmsUInt32Number* {aka unsigned int*}’ for argument<br>
> ‘3’ to ‘cmsBool cmsSaveProfileToMem(cmsHPROFILE, void*,<br>
> cmsUInt32Number*)’<br>
> cmsSaveProfileToMem(colorProfile, NULL, &profile_size);<br>
> ^<br>
> filter/rastertopdf.cpp:213:34: warning: ISO C++ forbids variable length<br>
> array ‘buff’ [-Wvla]<br>
> unsigned char buff[profile_size];<br>
> ^<br>
> filter/rastertopdf.cpp:214:56: error: cannot convert ‘size_t* {aka long<br>
> unsigned int*}’ to ‘cmsUInt32Number* {aka unsigned int*}’ for argument<br>
> ‘3’ to ‘cmsBool cmsSaveProfileToMem(cmsHPROFILE, void*,<br>
> cmsUInt32Number*)’<br>
> cmsSaveProfileToMem(colorProfile, buff, &profile_size);<br>
> ^<br>
> filter/rastertopdf.cpp: In function ‘int convert_raster(cups_raster_t*,<br>
> unsigned int, unsigned int, int, int, pdf_info*)’:<br>
> filter/rastertopdf.cpp:510:12: warning: unused variable ‘pixels’<br>
> [-Wunused-variable]<br>
> int i, pixels;<br>
> ^<br>
> filter/rastertopdf.cpp: In function ‘int main(int, char**)’:<br>
> filter/rastertopdf.cpp:697:18: warning: unused variable ‘val’<br>
> [-Wunused-variable]<br>
> const char *val; /* Option value */<br>
> ^<br>
> filter/rastertopdf.cpp: At global scope:<br>
> filter/rastertopdf.cpp:570:21: warning: ‘unsigned int<br>
> getCMSColorSpaceType(cmsColorSpaceSignature)’ defined but not used<br>
> [-Wunused-function]<br>
> static unsigned int getCMSColorSpaceType(cmsColorSpaceSignature cs)<br>
> ^<br>
> make[1]: *** [rastertopdf-rastertopdf.o] Error 1<br>
> make[1]: Leaving directory `/home/till/printing/cups/bzr/y'<br>
> make: *** [all] Error 2<br>
> till@till:~/printing/cups/bzr/y$<br>
><br>
><br>
><br>
> On 08/09/2014 01:32 AM, Joseph Simon wrote:<br>
> > Till,<br>
> ><br>
> > The lcms naming issue should be patched up in rev. 7250.<br>
> ><br>
> > Joe<br>
> ><br>
> ><br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>