win32 patch

Stef Walter stef at thewalter.net
Mon Jan 2 09:26:17 PST 2012


On 2012-01-02 16:59, Nikos Mavrogiannopoulos wrote:
> On Mon, Jan 2, 2012 at 1:01 PM, Stef Walter <stef-list at thewalter.net> wrote:
>> On 12/30/2011 10:38 PM, Nikos Mavrogiannopoulos wrote:
>>> Hello,
>>>  I needed to apply this patch in order to compile p11-kit with mingw64.
>>
>> Strange. Mike Cronenworth committed something a bit different to make it
>> work with mingw64.
>> http://cgit.freedesktop.org/p11-glue/p11-kit/commit/?id=336d8af58ea3d00a20a56937b11236a6bf2679dd
>> Which versions of p11-kit and mingw64 are you using? I just tested with
>> p11-kit master, and mingw64 version 1.0+20110523-1build2 on ubuntu and
>> it built fine as is.
> 
> Hi,
>  Mike asked the same information in private. I use mingw64 20110523 on
> ubuntu with p11-kit 0.9. If I use p11-kit-0.9 as distributed I get the

Could you try with git master? Mike's patch came after 0.9. I'll do
another release if it fixes the issue for you.

> error below (which was occurred also to another builder with mingw64).
> If I apply the previous patch I have no issues. In any case those
> definitions shouldn't be there because they look like a workaround in
> a specific mingw64 release bug. Maybe they should be defined only for
> the releases not having them causes problem.

The _WIN32_WINNT and _WIN32_IE definitions are very common in win32
code. They're used to try and make sure that you don't accidentally
depend on symbols in a later windows release than you're trying to target.

The WIN32_LEAN_AND_MEAN used to speed up compiler times, but maybe it's
not needed anymore. We could remove that one.

Cheers,

Stef

-- 

stef at thewalter.net
http://stef.thewalter.net


More information about the p11-glue mailing list