[packagekit] [PATCH] Bug #12883, PackageKit has a hard dependency on libnm_glib

[S.Çağlar Onur]

23 Eki 2007 Sal tarihinde, Richard Hughes şunları yazmıştı: 
> You don't need to include me in any of the pisi files :-)

OK, these are removed :)
 
> > +++ b/backends/pisi/helpers/pisiBackend.py
> ...
> > +        if self.installdb.has_package(package):
> > +            self.status(STATE_REMOVE)
> > +            try:
> > +                pisi.api.remove([package])
> > +            except pisi.Error,e:
> > +                self.error(ERROR_INTERNAL_ERROR, e)
> 
> Can we refine this error? What could go wrong?

For example PiSi won't remove any package belongs to system.base component for sake of system stability (this is the minimal base) and throws an error. There are 2-3 corner case 
exists for us.
 
> > +        else:
> > +            self.error(ERROR_INTERNAL_ERROR, "Package is not installed")
> 
> You want ERROR_PACKAGE_NOT_INSTALLED here.

Done...

> Other than that, it looks great, thanks.

Committed, thanks!

Cheers
-- 
S.Çağlar Onur <caglar at pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20071023/906cfbdc/attachment-0004.pgp>