[packagekit] [PATCH]Service Packs: Creation and Installation

Richard Hughes hughsient at gmail.com
Mon Aug 11 06:33:54 PDT 2008


On Mon, 2008-08-11 at 17:38 +0530, Shishir Goyal wrote:
> To nullify the posibility of the user's installing an incompatible*
> pack on their system, I have tried to add some metadata in the form of
> a file named metadata.conf to the packs while they are created.

Excellent. I've refactored 0001 slightly and committed it.

> Subsequently, upon installation the packs are checked against the then
> system distro_id.

0002 is incorrect, you need to do the check in src/pk-transaction.c
rather than client/pk-console.c -- if the user tries using
gpk-install-local-file or the QT bindings then this isn't going to be
checked. It shouldn't take too long to move the code, but make sure you
create a new error type to convey the failure to the developer.

Thanks.

Richard.





More information about the PackageKit mailing list