[packagekit] [PATCH] set packagekitd proxy environment variables

Richard Hughes hughsient at gmail.com
Mon Sep 13 05:59:03 PDT 2010


On 13 September 2010 13:43, Michael Meeks <michael.meeks at novell.com> wrote:
>        Since we fork curl ourselves we can control its environment - your
> patch here seems reasonable.
> http://gitorious.org/packagekit/xiaoqiangs-packagekit/commit/e977c3ae7b0185bdde2744bafa2d1d82b19fde62
>        assuming PK doesn't use the same vars itself.

No, this patch is *wrong* -- do not push it.

This patch sets the system proxy environment when the transaction is
scheduled. If the next transaction is not from the user that just
scheduled the transaction then the wrong proxy gets used. You need to
do this in the backend, or at very least in pk-backend.c

>        Richard - can we give xiaoqiang commit access to master so he can push
> approved fixes easily ? :-)

I think I've already added him.

Richard.



More information about the PackageKit mailing list