<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Tim Lauridsen wrote:
<blockquote cite="mid:48DF287F.5030801@googlemail.com" type="cite">Maybe
we should have an discussion about the use of pylint:<br>
<br>
<meta name="qrichtext" content="1">
<meta http-equiv="Content-Type" content="text/html; ">
<style type="text/css">
p, li { white-space: pre-wrap; }
</style>
<p style="margin: 0px; text-indent: 0px;"><!--StartFragment-->-
(name,
idver, a, repo) = self.get_package_from_id(package_id)</p>
<p style="margin: 0px; text-indent: 0px;">+ (name, _, _, repo) =
self.get_package_from_id(package_id)<br>
</p>
<p style="margin: 0px; text-indent: 0px;"><br>
A change like this, to silence pylint is bad IMHO. it is better to
disable the pylint check for unused vars.<br>
then to make this weird stuff, it really make the code harder to read
IMHO.<br>
</p>
<p style="margin: 0px; text-indent: 0px;">pyint is make made to check
the code for the coding standards done by the firm who has made pylint,
not<br>
for the upstream python coding standard, so a lot of checks has to be
disabled because they are totally insane.</p>
<p style="margin: 0px; text-indent: 0px;">pylint is good to find
error
in then code, but a lot of the coding standard stuff need to be turned
off.<br>
</p>
<p style="margin: 0px; text-indent: 0px;"><br>
Tim<br>
</p>
<p style="margin: 0px; text-indent: 0px;"><!--EndFragment--></p>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
PackageKit mailing list
<a class="moz-txt-link-abbreviated" href="mailto:PackageKit@lists.freedesktop.org">PackageKit@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/packagekit">http://lists.freedesktop.org/mailman/listinfo/packagekit</a>
</pre>
</blockquote>
<meta name="qrichtext" content="1">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css">
p, li { white-space: pre-wrap; }
</style>
<p style="margin: 0px; text-indent: 0px;"><!--StartFragment-->Another
case of pylint madness if to move methods to function outside because
self is not used.<br>
- self.error(ERROR_DEP_RESOLUTION_FAILED, self._format_msgs(msgs))</p>
<p style="margin: 0px; text-indent: 0px;">+
self.error(ERROR_DEP_RESOLUTION_FAILED, _format_msgs(msgs))<br>
</p>
<p style="margin: 0px; text-indent: 0px;"><br>
stuff like this really real make the code look bad and harder to
reader. private worker methods should not be moved out the class they<br>
are used in.<br>
<br>
</p>
<p style="margin: 0px; text-indent: 0px;">Tim<br>
</p>
<br>
<br>
</body>
</html>