[Piglit] [PATCH 1/4] gl-3.0: Verify linking errors to due invalid glBindFragDataLocation assignments

Ian Romanick idr at freedesktop.org
Wed Nov 16 13:50:35 PST 2011


From: Ian Romanick <ian.d.romanick at intel.com>

This test fails on AMD's closed-source driver and NVIDIA's
closed-source driver because they both allow an array to be assigned
to location GL_MAX_DRAW_BUFFERS-1.  See comments in the test for the
reasons this should be rejected.  AMD's closed-source driver also
fails to reject overlapping location assignments for 'a[1]' and 'v'.

v2: Verify that setting a and v to valid locations after a failing
link can link successfully.  Suggested by Paul Berry.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                 |    1 +
 tests/spec/gl-3.0/api/CMakeLists.gl.txt         |    1 +
 tests/spec/gl-3.0/api/bindfragdata-link-error.c |  190 +++++++++++++++++++++++
 3 files changed, 192 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/gl-3.0/api/bindfragdata-link-error.c

diff --git a/tests/all.tests b/tests/all.tests
index ef0b9bc..9f4f581 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -792,6 +792,7 @@ add_concurrent_test(gl20, 'vertex-program-two-side')
 gl30 = Group()
 spec['!OpenGL 3.0'] = gl30
 add_concurrent_test(gl30, 'bindfragdata-invalid-location')
+add_concurrent_test(gl30, 'bindfragdata-link-error')
 add_concurrent_test(gl30, 'clearbuffer-depth')
 add_concurrent_test(gl30, 'clearbuffer-depth-stencil')
 add_concurrent_test(gl30, 'clearbuffer-invalid-drawbuffer')
diff --git a/tests/spec/gl-3.0/api/CMakeLists.gl.txt b/tests/spec/gl-3.0/api/CMakeLists.gl.txt
index 466ffeb..f1b7a45 100644
--- a/tests/spec/gl-3.0/api/CMakeLists.gl.txt
+++ b/tests/spec/gl-3.0/api/CMakeLists.gl.txt
@@ -13,6 +13,7 @@ link_libraries (
 )
 
 add_executable (bindfragdata-invalid-parameters bindfragdata-invalid-parameters.c)
+add_executable (bindfragdata-link-error bindfragdata-link-error.c)
 add_executable (clearbuffer-depth clearbuffer-common.c clearbuffer-depth.c)
 add_executable (clearbuffer-depth-stencil clearbuffer-common.c clearbuffer-depth-stencil.c)
 add_executable (clearbuffer-invalid-drawbuffer clearbuffer-invalid-drawbuffer.c)
diff --git a/tests/spec/gl-3.0/api/bindfragdata-link-error.c b/tests/spec/gl-3.0/api/bindfragdata-link-error.c
new file mode 100644
index 0000000..20b764a
--- /dev/null
+++ b/tests/spec/gl-3.0/api/bindfragdata-link-error.c
@@ -0,0 +1,190 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file bindfragdata-link-error.c
+ *
+ * \author Ian Romanick
+ */
+#include "piglit-util.h"
+
+int piglit_width = 100, piglit_height = 100;
+int piglit_window_mode = GLUT_RGB | GLUT_DOUBLE;
+
+static const char *vs_text =
+	"#version 130\n"
+	"in vec4 vertex;\n"
+	"void main() { gl_Position = vertex; }\n"
+	;
+
+static const char *fs_text =
+	"#version 130\n"
+	"out vec4 v;\n"
+	"out vec4 a[2];\n"
+	"void main() {\n"
+	"    v = vec4(0.0);\n"
+	"    a[0] = vec4(1.0);\n"
+	"    a[1] = vec4(2.0);\n"
+	"}\n"
+	;
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+void piglit_init(int argc, char **argv)
+{
+	GLint max_draw_buffers;
+	GLuint prog;
+	GLuint vs;
+	GLuint fs;
+
+	piglit_require_gl_version(30);
+
+	/* This test needs some number of draw buffers, so make sure the
+	 * implementation isn't broken.  This enables the test to generate a
+	 * useful failure message.
+	 */
+	glGetIntegerv(GL_MAX_DRAW_BUFFERS, &max_draw_buffers);
+	if (max_draw_buffers < 8) {
+		fprintf(stderr,
+			"OpenGL 3.0 requires GL_MAX_DRAW_BUFFERS >= 8.  "
+			"Only got %d!\n",
+			max_draw_buffers);
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	prog = glCreateProgram();
+	vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vs_text);
+	fs = piglit_compile_shader_text(GL_FRAGMENT_SHADER, fs_text);
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	/* First, verify that the program will link without making any
+	 * location assignments through the API.
+	 */
+	printf("Basic test...\n");
+
+	glAttachShader(prog, vs);
+	glAttachShader(prog, fs);
+	glLinkProgram(prog);
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	if (!piglit_link_check_status(prog)) {
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	/* Page 237 (page 253 of the PDF) of the OpenGL 3.0 spec says:
+	 *
+	 *     "LinkProgram will fail if the assigned binding of a varying out
+	 *     variable would cause the GL to reference a non-existant
+	 *     fragment color number (one greater than or equal to MAX DRAW
+	 *     BUFFERS)."
+	 *
+	 * The array output has two elements.  Binding it to
+	 * GL_MAX_DRAW_BUFFERS - 1 causes a[0] to have a valid location but
+	 * a[1] to have an invalid location.
+	 *
+	 * This should not generate a GL error.  It should only cause linking
+	 * to fail.
+	 */
+	printf("Assigning `a' to GL_MAX_DRAW_BUFFERS - 1...\n");
+
+	glBindFragDataLocation(prog, 0, "v");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+	glBindFragDataLocation(prog, max_draw_buffers - 1, "a");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	glLinkProgram(prog);
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	if (piglit_link_check_status(prog)) {
+		fprintf(stderr,
+			"Linking was successful when it should have failed.\n");
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	/* Page 237 (page 253 of the PDF) of the OpenGL 3.0 spec says:
+	 *
+	 *     "LinkProgram will also fail if more than one varying out
+	 *     variable is bound to the same number. This type of aliasing is
+	 *     not allowed."
+	 *
+	 * Try this by assiging 'a[0]' and 'v' to the same slot, and also try
+	 * assigning 'a[1]' and 'v' to the same slot.
+	 *
+	 * This should not generate a GL error.  It should only cause linking
+	 * to fail.
+	 */
+	printf("Assigning `a[0]' and `v' to the same slot...\n");
+
+	glBindFragDataLocation(prog, 0, "v");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+	glBindFragDataLocation(prog, 0, "a");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	glLinkProgram(prog);
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	if (piglit_link_check_status(prog)) {
+		fprintf(stderr,
+			"Linking was successful when it should have failed.\n");
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	printf("Assigning `a[1]' to `v' to the same slot...\n");
+
+	glBindFragDataLocation(prog, 1, "v");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+	glBindFragDataLocation(prog, 0, "a");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	glLinkProgram(prog);
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	if (piglit_link_check_status(prog)) {
+		fprintf(stderr,
+			"Linking was successful when it should have failed.\n");
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	printf("Assigning `a' to `v' to non-overlapping slots...\n");
+
+	glBindFragDataLocation(prog, 0, "v");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+	glBindFragDataLocation(prog, 2, "a");
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	glLinkProgram(prog);
+	piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+
+	if (!piglit_link_check_status(prog)) {
+		fprintf(stderr,
+			"Linking failed when it should have been "
+			"successful.\n");
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+
+	piglit_report_result(PIGLIT_PASS);
+}
-- 
1.7.6.4



More information about the Piglit mailing list