[Piglit] [PATCH 3/4] Make piglit_probe_image_rgb[a] continue probing even after a bad pixel.

Eric Anholt eric at anholt.net
Wed Nov 30 05:05:52 PST 2011


On Tue, 29 Nov 2011 23:32:29 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> piglit_probe_image_rgba is supposed to probe a whole rectangle's worth
> of pixels, comparing them against the supplied image.  Previously, it
> would stop probing after it found one incorrect pixel, failing to report
> any other bad pixels.  This was misleading since silence usually means
> "probe was correct".

I'm lost.  How would you get silence despite having found a bad pixel?
Did you mean "silence about the other pixels"?

The intent was "once one pixel is bad, it's quite likely that a whole
lot of pixels are bad, so don't spam an observed/expected combination
for the other probably (w * h - 1) pixels".  I'm betting that this
behavior is desired way more often than "keep probing and spamming after
a bad one".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111130/4e301c6b/attachment.pgp>


More information about the Piglit mailing list