[Piglit] [PATCH v3 4/5] Fix too-specific GL version checks in glean
brianp at vmware.com
Tue Oct 18 12:22:10 PDT 2011
On 10/18/2011 01:20 PM, Paul Berry wrote:
> On 14 October 2011 14:33, Brian Paul <brianp at vmware.com
> <mailto:brianp at vmware.com>> wrote:
> On 10/14/2011 02:15 PM, Paul Berry wrote:
> On 14 October 2011 07:45, Brian Paul <brianp at vmware.com
> <mailto:brianp at vmware.com>
> <mailto:brianp at vmware.com <mailto:brianp at vmware.com>>> wrote:
> On 10/13/2011 02:45 PM, Paul Berry wrote:
> This patch fixes several version checks in glean that
> are too
> (e.g. checking that the GL version is 2.x or 3.x when the
> intent is to
> make sure the GL version is>= 2.0).
> We now perform the version check using the piglit-util
> piglit_is_gles() and piglit_get_gl_version() rather
> than manually
> inspecting the GL_VERSION string, so this makes the glean
> tests depend
> on the piglitutil library.
> Hmmm, I think it would be cleaner if this was fixed in
> glean. It should be trivial to write a
> Also, I don't think glean has ever been used with ES so
> I don't
> think we need to check for ES in the glean tests (or if we
> do, it
> should probably be done everywhere).
> I don't know when glean was last imported into piglit, but
> have been some assorted fixes there.
> If you can develop a patch, I'd push it there for you.
> Oh, I didn't realize glean was being independently maintained.
> I'll develop a patch that can be submitted upstream. Where
> should I
> send it?
> There's a glean-dev list hosted on sourceforge. Otherwise, you
> can just send it to me and I'll push it.
> Ok, I sent a patch to you. Are you planning to cherry-pick it over to
> Piglit or do you need me to do that?
I'll test/push it to the glean repo soon.
I believe there's a glean branch in the piglit repo. You'd pull glean
into that branch then merge it into master, I think. Someone else
should probably confirm that.
More information about the Piglit