[Piglit] [PATCH 1/1] Add a small ARB_draw_buffers test.
eric at anholt.net
Tue Sep 20 11:39:01 PDT 2011
On Tue, 20 Sep 2011 00:26:56 +0200, Henri Verbeet <hverbeet at gmail.com> wrote:
> On 20 September 2011 00:08, Eric Anholt <eric at anholt.net> wrote:
> > On Sat, 17 Sep 2011 23:20:02 +0200, Henri Verbeet <hverbeet at gmail.com> wrote:
> >> Signed-off-by: Henri Verbeet <hverbeet at gmail.com>
> > We have a few tests of ARB_draw_buffers under fbo/fbo-drawbuffers*. It
> > would be nice to see this test explain how it relates to them (what's
> > different, or if there's a particular bug it's testing for).
> This test tests that glDrawBuffersARB() selects the correct buffers,
> as opposed to testing that drawing to those buffers works as intended.
> It's related to
> (It took a bit longer than expected to get back to that.)
Since it's regression testing such a specific bug, it would be nice to
see that mentioned in the testcase, so someone doing some cleanup
doesn't go and accidentally trash it :) I think I might name the
testcase "statechange-bug" or something like that. Also, in piglit we
go for 8-space tab indents, kernel-style. Other than that, looks good
and the code is quite simple and readable.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the Piglit