[Piglit] [PATCH] framework: Fix test exclude filtering

He, Shuang shuang.he at intel.com
Mon Feb 20 17:46:19 PST 2012


Thanks for fixing this :)
And sorry for top-posting (damn mail box failure)

Thanks
	--Shuang

-----Original Message-----
From: Kenneth Graunke [mailto:kenneth at whitecape.org] 
Sent: Friday, February 17, 2012 5:44 PM
To: He, Shuang
Cc: piglit at lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] framework: Fix test exclude filtering

On 02/16/2012 05:05 PM, Shuang He wrote:
> The key to look up in dict may have been filtered out in previous filtering
>
> Signed-off-by: Shuang He<shuang.he at intel.com>
> ---
>   framework/core.py |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/framework/core.py b/framework/core.py
> index 2414709..ea4b078 100644
> --- a/framework/core.py
> +++ b/framework/core.py
> @@ -525,6 +525,7 @@ class TestProfile:
>   			# Exclude tests that don't match any of the `filter' regexps (-t options)
>   			if env.filter and not matches_any_regexp(path, env.filter):
>   				del self.test_list[path]
> +				continue
>
>   			# Exclude tests that match an `exclude_filter' regexp (-x options)
>   			if env.exclude_filter and matches_any_regexp(path, env.exclude_filter):

Sorry for breaking this.  I just sent out an alternate patch that 
simplifies this code and should fix the problem.

It's [PATCH 1/4] framework: Fix filtering of excluded tests.


More information about the Piglit mailing list