[Piglit] [PATCH] Add test case to verify large textures are handled correctly in mesa
brianp at vmware.com
Fri Mar 16 08:29:15 PDT 2012
On 03/16/2012 08:50 AM, Brian Paul wrote:
> On 03/15/2012 01:20 PM, Anuj Phogat wrote:
>> Brian, does this test still takes long time to finish on nvidia? I 'll
>> push it if there are no pending issues.
> It seems to run much faster now without the loop. Thanks.
> However, I'm seeing crashes with some gallium drivers. Would you mind
> waiting a few more days so that I can check that out?
Actually, I quickly I found the problem in the mesa state tracker.
But I think the piglit test can be improved a little bit more.
1. In piglit_init() there's two loops which are basically identical,
except for the last parameter passed to ValidateTexSize(). I think
you could loop over proxy=true/false and remove the redundant code.
2. Also, the code as-is seems to be missing a glDeleteTextures() call
at line 448 (using the loop would fix that).
3. You don't actually need to create any texture objects when testing
More information about the Piglit