[Piglit] [PATCH 2/4] textureSize: Add support for running these tests in GLSL 1.40 mode.

Eric Anholt eric at anholt.net
Fri Mar 16 14:15:30 PDT 2012


On Thu, 15 Mar 2012 15:17:32 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> I'm not really sure that it's worth adding a 140 command line option. 
> I'd be inclined to just force 140 if the sampler type is sampler2DRect 
> (including i/u variants) or samplerBuffer.
> 
> That will have implications on the rest of this series.
> 
> Ian/Chad/others may disagree with me though.
> 
> Either way, this series is:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I agreed with you, and went to go start writing the change.  Then I
noticed that GL_EXT_gpu_shader4 also introduces 2DRect to these texture
functions.  I think we should keep the change like this so that we can
test them independently when we get to that point.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120316/9c6a913c/attachment.pgp>


More information about the Piglit mailing list