[Piglit] [PATCH 1/2] gtf: Upstream appears to have switched to imagefileio off by default.

Chad Versace chad.versace at linux.intel.com
Tue Apr 9 18:35:19 PDT 2013


On 04/08/2013 03:39 PM, Eric Anholt wrote:
> ---
>   tests/gtf.tests |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gtf.tests b/tests/gtf.tests
> index 1d0070a..4cbbd2c 100644
> --- a/tests/gtf.tests
> +++ b/tests/gtf.tests
> @@ -45,7 +45,7 @@ class GTFTest(ExecTest):
>       pass_re = re.compile(r'Regression PASSED all 1 tests')
>
>       def __init__(self, testpath):
> -        ExecTest.__init__(self, [path.join(testBinDir, 'GTF'), '-noimagefileio', '-width=113', '-height=47', '-seed=2', '-minfmt', '-run=' + testpath])
> +        ExecTest.__init__(self, [path.join(testBinDir, 'GTF'), '-width=113', '-height=47', '-seed=2', '-minfmt', '-run=' + testpath])
>
>       def interpretResult(self, out, returncode, results):
>   	if self.pass_re.search(out) is not None:

A little more commit message here would be good. Upstream has changed
the default arguments... ok, but what does the patch do? That little
extra doesn't help much for patch review, but it does help when reading
the git log.

Anyways, for both patches
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>




More information about the Piglit mailing list