[Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

[Brian Paul]

OK, I thought you had git-write ability.  I'll commit/push soon.

-Brian

On 02/07/2013 08:23 AM, Tom Gall wrote:
> Hi Brian,
>
> It has your reviewed by.
>
> Ideally I was looking for it to be committed unless of course there's
> something egregious about it that we both missed.
>
> On Thu, Feb 7, 2013 at 9:04 AM, Brian Paul<brianp at vmware.com>  wrote:
>> LGTM.  Are you asking for another review or do you need someone to
>> commit/push it for you?
>>
>> -Brian
>>
>>
>> On 02/06/2013 03:38 PM, Tom Gall wrote:
>>>
>>> It was a little over two weeks ago when v2 of these 2 patches to port
>>> ttexrect to piglit and remove it from glean were posted.
>>>
>>> It has a Reviewed-by: Brian Paul<brianp at vmware.com>
>>>
>>> Any reason why this shouldn't go in?
>>>
>>> Thanks.
>>>
>>> ---------- Forwarded message ----------
>>> From: Brian Paul<brianp at vmware.com>
>>> Date: Mon, Jan 21, 2013 at 4:46 PM
>>> Subject: Re: [Piglit] [PATCH 1/2] port ttexrect.cpp to piglit from glean
>>> To: Tom Gall<tom.gall at linaro.org>
>>> Cc: piglit at lists.freedesktop.org, patches at linaro.org
>>>
>>>
>>> On 01/21/2013 01:43 PM, Tom Gall wrote:
>>>>
>>>>
>>>> This ported test goes into tests/spec/arb_texture_rectangle. It
>>>> tests the ARB_texture_rectangle extension.
>>>>
>>>> Create a 255x127 texture of varying colors and bind it as a
>>>> GL_ARB_texture_recangle target.  Draw that rectangle to the window, and
>>>> check that the texture was drawn correctly.  The common failure to be
>>>> caught with this test is not adjusting the non-normalized coordinates on
>>>> hardware that expects normalized coordinates.
>>>>
>>>> To all.tests, add new texrect_simple_arb_texrect
>>>>
>>>> v2: add PIGLIT_GL_VISUAL_DOUBLE to the window_visual, move various
>>>> setup bits to piglit_init and add forgotten all.tests change.
>>>>
>>>> Signed-off-by: Tom Gall<tom.gall at linaro.org>
>>>
>>>
>>>
>>> For both:
>>> Reviewed-by: Brian Paul<brianp at vmware.com>
>>>
>>>
>>> --
>>> Regards,
>>> Tom
>>>
>>> "Where's the kaboom!? There was supposed to be an earth-shattering
>>> kaboom!" Marvin Martian
>>> Tech Lead, Graphics Working Group | Linaro.org │ Open source software
>>> for ARM SoCs
>>> w) tom.gall att linaro.org
>>> h) tom_gall att mac.com
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit
>>
>>
>
>
>
> --
> Regards,
> Tom
>
> "Where's the kaboom!? There was supposed to be an earth-shattering
> kaboom!" Marvin Martian
> Tech Lead, Graphics Working Group | Linaro.org │ Open source software
> for ARM SoCs
> w) tom.gall att linaro.org
> h) tom_gall att mac.com