[Piglit] [PATCH] gs: Check GL errors in primitive-id-restart test.

Jordan Justen jljusten at gmail.com
Fri Oct 11 21:17:35 CEST 2013


Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On Fri, Oct 11, 2013 at 11:36 AM, Paul Berry <stereotype441 at gmail.com> wrote:
> Previously, if drawing failed due to a GL error, no primitives would
> be generated, so the test would have nothing to check, and it would
> erroneously pass.  Avoid that by checking for GL errors at the end of
> the test.
> ---
>  tests/spec/glsl-1.50/execution/geometry/primitive-id-restart.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/spec/glsl-1.50/execution/geometry/primitive-id-restart.c b/tests/spec/glsl-1.50/execution/geometry/primitive-id-restart.c
> index d436e21..4baa4be 100644
> --- a/tests/spec/glsl-1.50/execution/geometry/primitive-id-restart.c
> +++ b/tests/spec/glsl-1.50/execution/geometry/primitive-id-restart.c
> @@ -262,6 +262,8 @@ piglit_init(int argc, char **argv)
>         }
>         glUnmapBuffer(GL_TRANSFORM_FEEDBACK_BUFFER);
>
> +       pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
> +
>         piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
>  }
>
> --
> 1.8.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list