[Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

Jordan Justen jljusten at gmail.com
Tue Oct 29 19:24:11 CET 2013


On Fri, Oct 25, 2013 at 9:41 AM, Jon Ashburn <jon at lunarg.com> wrote:
> RE your comment:
>
>> +    config.window_width = 128;
>> +    config.window_height = 128;
>
>
> "Is 128 special?  Can you just go with the defaults?  In the past we've had
> trouble on Windows when the width is < 130 or so pixels.  Long story. "
>
>
> 128 isn't special  and I could use a larger number (>130). However, since a
> line is drawn diagonally across the full screen and sampled in its middle by
> this test, certain width and height combinations  fail.

Drawing a line doesn't seem too important to this test. Could a rect
be used instead to allow for larger variance in sizes to function? For
example, what if the default size was 150 for Windows, but something
small for Linux?

-Jordan

>  The default values
> work but I am worried about the user overiding  the default value (not sure
> how that behaves). Other option is to make the test  more robust to varying
> window width and heights rather than fixing the window width and height to a
> value that samples correctly.
>
> Jon


More information about the Piglit mailing list