[Piglit] [PATCH 00/24] ARB_direct_state_access texture tests

Laura Ekstrand laura at jlekstrand.net
Mon Dec 15 17:24:03 PST 2014


These tests test ARB_direct_state_access texture functions.  Since DSA functions and traditional functions typically share the same backend implementation, some of the simpler or more obscure functions (such as glCompressedTextureSubImage1D) are only tested trivially.  Moreover, many of the more sophisticated tests were adapted from tests of similar non-DSA functions.  During the adaptation process, I tried where it was possible and sensible to leave behind a mix of traditional and DSA function calls in order to test interactions between them.  In cases of brand-new GL API functions, such as glCreateTextures, I wrote new tests.

Some of these tests check whether or not the DSA function calls throw the correct errors.  In the process of checking errors for glTextureParameter*, Dylan Baker and I discovered that some errors changed beginning in the OpenGL 4.3 core spec.  For this reason, I updated some of the previously existing Piglit tests to conform to the OpenGL 4.5 core spec;  the new error style is more uniform with the OpenGL ES 3.1 spec.

Dylan Baker (3):
  arb_direct_state_access: Add tests for non-generated texture object
    names     passed to glTextureParameter.
  arb_direct_state_access: Add additional error checking for
    *TextureParameter
  arb_direct_state_access: Most error checking for TextureParameter
    functions

Laura Ekstrand (21):
  arb_direct_state_access: DSA 2D Textures "hello world" test.
  arb_direct_state_access: glTextureSubImage*D test.
  arb_direct_state_access: Testing glBindTextureUnit.
  arb_direct_state_access: Added glCreateTextures test.
  arb_direct_state_access: Added glTextureStorage*D test.
  arb_direct_state_access: DSA texunits test (adapted from
    tests/general)
  arb_direct_state_access: Added test for TextureParameter* and
    GetTextureParameter*.
  arb_direct_state_access: Added tests for glGetTexLevelParameterfv to
    texture-storage.c
  arb_direct_state_access: Added tests for CopyTextureSubImage*D.
  arb_direct_state_access: Tests for glGetTextureImage.
  arb_direct_state_access: Added tests for glGetCompressedTextureImage.
  arb_direct_state_access: Modified gettexture-image-formats.c to test
    glGenerateTextureMipmap.
  arb_direct_state_access: Added a test for
    glTextureStorage2DMultisample.
  arb_direct_state_access: Using glTextureStorage2DMultisample for
    something not completely trivial.
  arb_direct_state_access: Testing glTextureStorage3DMultisample.
  arb_direct_state_access: Added test for glCompressedTextureSubImage1D.
  arb_direct_state_access: Added test for glTextureBuffer.
  general: Testing really basic texture errors.
  arb_texture_rectangle: Updated error conditions to match the OpenGL
    4.5 and ES 3.1 core specs.
  arb_texture_storage_multisample: Updated error conditions to match the
    OpenGL 4.5 and ES 3.1 core specs.
  ext_packed_float: Refactored the
    getteximage-invalid-format-for-packed-type.c test.

 tests/all.py                                       |  21 +
 tests/general/CMakeLists.gl.txt                    |   1 +
 tests/general/tex-errors.c                         |  74 +++
 tests/spec/CMakeLists.txt                          |   1 +
 .../spec/arb_direct_state_access/CMakeLists.gl.txt |  30 +
 tests/spec/arb_direct_state_access/CMakeLists.txt  |   1 +
 .../arb_direct_state_access/bind-texture-unit.c    |  78 +++
 .../compressedtextureimage.c                       | 288 ++++++++++
 .../arb_direct_state_access/copytexturesubimage.c  | 293 ++++++++++
 .../spec/arb_direct_state_access/create-textures.c |  80 +++
 tests/spec/arb_direct_state_access/dsa-textures.c  | 123 ++++
 tests/spec/arb_direct_state_access/dsa-utils.c     |  79 +++
 tests/spec/arb_direct_state_access/dsa-utils.h     |  51 ++
 tests/spec/arb_direct_state_access/get-textures.c  | 114 ++++
 .../getcompressedtextureimage.c                    | 433 ++++++++++++++
 .../gettextureimage-formats.c                      | 558 ++++++++++++++++++
 .../gettextureimage-luminance.c                    | 260 +++++++++
 .../gettextureimage-simple.c                       |  86 +++
 .../gettextureimage-targets.c                      | 305 ++++++++++
 .../spec/arb_direct_state_access/texture-buffer.c  | 106 ++++
 .../spec/arb_direct_state_access/texture-errors.c  | 475 ++++++++++++++++
 .../spec/arb_direct_state_access/texture-params.c  | 204 +++++++
 .../texture-storage-multisample.c                  | 481 ++++++++++++++++
 .../spec/arb_direct_state_access/texture-storage.c | 624 +++++++++++++++++++++
 .../spec/arb_direct_state_access/texturesubimage.c | 415 ++++++++++++++
 tests/spec/arb_direct_state_access/texunits.c      | 383 +++++++++++++
 .../texture-base-level-error.c                     |  35 +-
 .../arb_texture_storage_multisample/tex-param.c    |  86 ++-
 .../getteximage-invalid-format-for-packed-type.c   | 105 ++--
 tests/util/piglit-util-gl.c                        |   2 +-
 tests/util/piglit-util-gl.h                        |   1 +
 31 files changed, 5716 insertions(+), 77 deletions(-)
 create mode 100644 tests/general/tex-errors.c
 create mode 100644 tests/spec/arb_direct_state_access/CMakeLists.gl.txt
 create mode 100644 tests/spec/arb_direct_state_access/CMakeLists.txt
 create mode 100644 tests/spec/arb_direct_state_access/bind-texture-unit.c
 create mode 100644 tests/spec/arb_direct_state_access/compressedtextureimage.c
 create mode 100644 tests/spec/arb_direct_state_access/copytexturesubimage.c
 create mode 100644 tests/spec/arb_direct_state_access/create-textures.c
 create mode 100644 tests/spec/arb_direct_state_access/dsa-textures.c
 create mode 100644 tests/spec/arb_direct_state_access/dsa-utils.c
 create mode 100644 tests/spec/arb_direct_state_access/dsa-utils.h
 create mode 100644 tests/spec/arb_direct_state_access/get-textures.c
 create mode 100644 tests/spec/arb_direct_state_access/getcompressedtextureimage.c
 create mode 100644 tests/spec/arb_direct_state_access/gettextureimage-formats.c
 create mode 100644 tests/spec/arb_direct_state_access/gettextureimage-luminance.c
 create mode 100644 tests/spec/arb_direct_state_access/gettextureimage-simple.c
 create mode 100644 tests/spec/arb_direct_state_access/gettextureimage-targets.c
 create mode 100644 tests/spec/arb_direct_state_access/texture-buffer.c
 create mode 100644 tests/spec/arb_direct_state_access/texture-errors.c
 create mode 100644 tests/spec/arb_direct_state_access/texture-params.c
 create mode 100644 tests/spec/arb_direct_state_access/texture-storage-multisample.c
 create mode 100644 tests/spec/arb_direct_state_access/texture-storage.c
 create mode 100644 tests/spec/arb_direct_state_access/texturesubimage.c
 create mode 100644 tests/spec/arb_direct_state_access/texunits.c

-- 
2.1.0



More information about the Piglit mailing list