[Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

Matt Turner mattst88 at gmail.com
Mon Dec 15 20:27:44 PST 2014


On Mon, Dec 15, 2014 at 7:11 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Dec 15, 2014 at 5:01 PM, Vinson Lee <vlee at freedesktop.org> wrote:
>> On Mon, Dec 15, 2014 at 11:05 AM, Matt Turner <mattst88 at gmail.com> wrote:
>>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit
>>
>>
>> This patch introduced two GCC warnings.
>>
>> glsl-deriv-varyings.c:108:20: warning: ‘fragShaderText4’ defined but
>> not used [-Wunused-variable]
>>  static const char *fragShaderText4 =
>>                     ^
>> glsl-deriv-varyings.c:118:20: warning: ‘fragShaderText5’ defined but
>> not used [-Wunused-variable]
>>  static const char *fragShaderText5 =
>>                     ^
>
> Whoops, thanks Vinson. That's a pretty bad oops :)
>
> I'll take care of it.

I fixed the glShaderSource() calls and the missing ) in
fragShaderText5, but the fifth shader doesn't pass. From a quick
glance, it's not clear why. Andres?


More information about the Piglit mailing list