[Piglit] [PATCH] vertex-attrib-pointer-type-size-match: use a VAO for GL 3.0 and later.

Matt Turner mattst88 at gmail.com
Thu Jul 17 11:36:02 PDT 2014


On Thu, Jul 17, 2014 at 6:26 AM, Brian Paul <brianp at vmware.com> wrote:
> With GL 3.0 and later, all vertex arrays must be in a vertex array object.
> This fixes the test with Mesa.

Isn't it 3.1 (i.e., specifically core profiles) and later?

> ---
>  .../vertex-attrib-pointer-type-size-match.c                      |    6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tests/spec/arb_vertex_type_2_10_10_10_rev/vertex-attrib-pointer-type-size-match.c b/tests/spec/arb_vertex_type_2_10_10_10_rev/vertex-attrib-pointer-type-size-match.c
> index 6eb9596..5f0f0b9 100644
> --- a/tests/spec/arb_vertex_type_2_10_10_10_rev/vertex-attrib-pointer-type-size-match.c
> +++ b/tests/spec/arb_vertex_type_2_10_10_10_rev/vertex-attrib-pointer-type-size-match.c
> @@ -53,6 +53,12 @@ piglit_init(int argc, char **argv)
>         GLint invalid_sizes[] = {
>                 1, 2, 3
>         };
> +       GLuint array_obj;
> +
> +       if (piglit_get_gl_version() >= 30) {

s/30/31/ (unless my understanding is wrong) and this gets a

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the Piglit mailing list