[Piglit] [PATCH] Revert "python: change she-bang to python2"

Dylan Baker baker.dylan.c at gmail.com
Mon Jun 23 17:36:13 PDT 2014


Chad, you mentioned you had comments on this patch?

On Friday, June 20, 2014 12:04:01 AM Dylan Baker wrote:
> This reverts commit 40b5d5288991fec2cc76ea4af7050555be467126.
> 
> The patch to be reverted breaks users of *BSD, solaris, and OSX which
> don't provide a python2 symlink, making it a regression.
> 
> The patch however, fixes python for arch users whos python executable
> incorrectly is python3. This is a bug that Arch is not willing to fix.
> 
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80261
> ---
>  generate-glean-tests.py  | 2 +-
>  piglit                   | 2 +-
>  piglit-merge-results.py  | 2 +-
>  piglit-print-commands.py | 2 +-
>  piglit-resume.py         | 2 +-
>  piglit-run.py            | 2 +-
>  piglit-summary-html.py   | 2 +-
>  piglit-summary-junit.py  | 2 +-
>  piglit-summary.py        | 2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/generate-glean-tests.py b/generate-glean-tests.py
> index aafe256..df08ede 100755
> --- a/generate-glean-tests.py
> +++ b/generate-glean-tests.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  #
>  # Copyright © 2010 Intel Corporation
> diff --git a/piglit b/piglit
> index 616e408..ea73268 100755
> --- a/piglit
> +++ b/piglit
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> 
>  # Copyright (c) 2014 Intel Corporation
> 
> diff --git a/piglit-merge-results.py b/piglit-merge-results.py
> index a6c0065..e78a5d0 100755
> --- a/piglit-merge-results.py
> +++ b/piglit-merge-results.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
>  #
>  # Permission is hereby granted, free of charge, to any person
>  # obtaining a copy of this software and associated documentation
> diff --git a/piglit-print-commands.py b/piglit-print-commands.py
> index d88ab1c..635d27c 100755
> --- a/piglit-print-commands.py
> +++ b/piglit-print-commands.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
>  #
>  # Permission is hereby granted, free of charge, to any person
>  # obtaining a copy of this software and associated documentation
> diff --git a/piglit-resume.py b/piglit-resume.py
> index 6b78529..195a5db 100755
> --- a/piglit-resume.py
> +++ b/piglit-resume.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> 
>  # Copyright (c) 2014 Intel Corporation
> 
> diff --git a/piglit-run.py b/piglit-run.py
> index 4c0f878..7c2d71a 100755
> --- a/piglit-run.py
> +++ b/piglit-run.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> 
>  # Copyright (c) 2014 Intel Corporation
> 
> diff --git a/piglit-summary-html.py b/piglit-summary-html.py
> index 4b5278e..078c7cb 100755
> --- a/piglit-summary-html.py
> +++ b/piglit-summary-html.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> 
>  # Copyright (c) 2014 Intel Corporation
> 
> diff --git a/piglit-summary-junit.py b/piglit-summary-junit.py
> index 5c40a73..5aa1969 100755
> --- a/piglit-summary-junit.py
> +++ b/piglit-summary-junit.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> 
>  # Copyright (c) 2014 Intel Corporation
> 
> diff --git a/piglit-summary.py b/piglit-summary.py
> index d1294be..c5a3923 100755
> --- a/piglit-summary.py
> +++ b/piglit-summary.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> 
>  # Copyright (c) 2014 Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140623/7e0c4037/attachment-0001.sig>


More information about the Piglit mailing list