[Piglit] [PATCH] all.py: Actually add_texwrap_target_tests's target parameter to the test.

[Dylan Baker]

Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
On Jun 18, 2015 6:11 AM, "Jose Fonseca" <jfonseca at vmware.com> wrote:

> The target was only being used for the test name -- all test instances
> were duplicate of one another.
>
> Noticed this because llvmpipe started failing several tests when offset
> was added, and all test command lines were exactly the same.
> ---
>  tests/all.py | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index 2839059..f462972 100755
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -151,13 +151,15 @@ def add_vpfpgeneric(adder, name):
>
>
>  def add_texwrap_target_tests(adder, target):
> -    adder(['texwrap', 'GL_RGBA8'], 'texwrap {}'.format(target))
> -    adder(['texwrap', 'GL_RGBA8', 'offset'],
> +    adder(['texwrap', target, 'GL_RGBA8'],
> +          'texwrap {}'.format(target))
> +    adder(['texwrap', target, 'GL_RGBA8', 'offset'],
>            'texwrap {} offset'.format(target))
> -    adder(['texwrap', 'GL_RGBA8', 'bordercolor'],
> +    adder(['texwrap', target, 'GL_RGBA8', 'bordercolor'],
>            'texwrap {} bordercolor'.format(target))
> -    adder(['texwrap', 'GL_RGBA8', 'proj'], 'texwrap {}
> proj'.format(target))
> -    adder(['texwrap', 'GL_RGBA8', 'proj', 'bordercolor'],
> +    adder(['texwrap', target, 'GL_RGBA8', 'proj'],
> +          'texwrap {} proj'.format(target))
> +    adder(['texwrap', target, 'GL_RGBA8', 'proj', 'bordercolor'],
>            'texwrap {} proj bordercolor'.format(target))
>
>
> --
> 2.1.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150618/545e3c0f/attachment.html>