[Piglit] [PATCH 0/7] Replace the '/' in groups with '@'

Ian Romanick idr at freedesktop.org
Mon Mar 16 16:53:53 PDT 2015


On 03/12/2015 03:42 PM, Dylan Baker wrote:
> This series replaces the '/' separator in groups with '@', in the
> process it works to make another such change easier by using a constant
> for the separator.
> 
> This stems from problems with os.path.join being intertwined with
> grouptools, which happens to work currently on posix systems, but breaks
> utterly on windows. 
> 
> This series also makes a number of cleanups as this new constant
> enables.
> 
> Finally, why @?
> 
> Well, I first considered |, but glean uses that in a test name. Then I
> considered #, but glean uses that in a test name, then I considered !,
> but the opengl groups are prefaced with that, then I considered >, but
> glean uses that, then I considered &, but glean uses that.  At that
> point I picked @, since I know it will a) render on dumb terminals, and
> b) glean doesn't have a test with @ in the name.

Good grief.  That sounds like three more reasons to kill the rest of glean.



More information about the Piglit mailing list