[Piglit] [PATCH] Porting basic GL rendering tests to piglit

[Emil Velikov]

On 2 September 2015 at 23:17, Juliet Fru <julietfru at gmail.com> wrote:
> Hello Emil,
>
>> > +enum piglit_result
>> > +piglit_display(void)
>> > +{
>> > +       bool pass = true;
>> > +       enum path p, paths[10];
>> > +       int i, num_paths = 0;
>> > +
>> > +       static const float white[3] = {1.0, 1.0, 1.0};
>> > +
>> > +       /* draw 10x10 pixel quads */
>> > +       glViewport(0, 0, 10, 10);
>> > +
>> > +       glDisable(GL_DITHER);
>> > +
>> > +       /* Build the list of paths to exercise */
>> > +       for (p = ALPHA; p != ZZZ; p = (enum path) (p + 1)) {
>> > +               paths[num_paths++] = p;
>> > +       }
>> > +
>> The original test skips depth/stencil tests when we do not have the
>> buffer. As you've dropped both the checks and the comment does that
>> mean the tests work/pass ? Shouldn't we add the appropriate
>> PIGLIT_GL_VISUAL to the config ?
>
>
> I am sorry I missed that, but that should be included in the config. I'm not
> very sure on how to do this.
>
Afaics adding PIGLIT_GL_VISUAL_DEPTH and PIGLIT_GL_VISUAL_STENCIL to
the config.window_visual should suffice. Never had the pleasure of
using them, but things ought to just work.

-Emil