[Piglit] [PATCH 08/16] namespace-pollution: Add glGetTexImage as an operation to test

[Ian Romanick]

On 01/07/2016 10:07 AM, Ilia Mirkin wrote:
> On Thu, Jan 7, 2016 at 1:04 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 01/07/2016 09:31 AM, Emil Velikov wrote:
>>> On 7 January 2016 at 02:53, Ian Romanick <idr at freedesktop.org> wrote:
>>>
>>>>  static bool
>>>> +do_GetTexImage(bool silent_skip)
>>>> +{
>>>
>>>> +       generate_random_data(data, sizeof(data), GL_PIXEL_UNPACK_BUFFER, pbo);
>>> GL_TEXTURE_2D ?
>>
>> It doesn't matter what is used.  The last two parameters to
>> generate_random_data are just the initial random number seeds.  The data
>> generated for this texture (and the similar texture in patch 12) is
>> never examined.  We just need some data in the texture to read back for
>> the glGetTexImage call.
>>
>> This also means the change that Ilia pointed out in patch 13 is
>> completely spurious.  I'll remove that.
> 
> Not *completely*... the s/pbo/tex bit was important iirc. The specific
> pname doesn't matter, obviously.

I just noticed that. :)  I'll move the s/pbo/tex/ bit to patch 12 where
it belongs.

>   -ilia