[Piglit] [PATCH] piglit-fbo: check the proper extension dependency when attaching a color texture

Anuj Phogat anuj.phogat at gmail.com
Thu Jan 14 09:28:07 PST 2016


On Thu, Jan 14, 2016 at 4:35 AM, Alejandro PiƱeiro <apinheiro at igalia.com> wrote:
> attach_color_texture uses TEXTURE_RECTANGLE, so it should check
> for GL_ARB_texture_rectangle.
>
> attach_multisample_color_texture uses multisample texture targets,
> so it should check for GL_ARB_texture_multisample.
>
> Before this patch, the dependency check was wrongly switched.
> ---
>  tests/util/piglit-fbo.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/util/piglit-fbo.cpp b/tests/util/piglit-fbo.cpp
> index bc705aa..1c4cd6c 100644
> --- a/tests/util/piglit-fbo.cpp
> +++ b/tests/util/piglit-fbo.cpp
> @@ -208,14 +208,14 @@ Fbo::try_setup(const FboConfig &new_config)
>                 if (config.num_samples == 0) {
>
>                         /* Attach textures as color attachments */
> -                       piglit_require_extension("GL_ARB_texture_multisample");
> +                       piglit_require_extension("GL_ARB_texture_rectangle");
>                         for (int i = 0; i < config.num_tex_attachments; i++)
>                                 attach_color_texture(new_config, i);
>
>                 } else {
>
>                         /* Attach multisample textures as color attachments */
> -                       piglit_require_extension("GL_ARB_texture_rectangle");
> +                       piglit_require_extension("GL_ARB_texture_multisample");
>                         for (int i = 0; i < config.num_tex_attachments; i++)
>                                 attach_multisample_color_texture(new_config, i);
>                 }
> --
> 2.1.4
>

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the Piglit mailing list